Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Cantera installation to source directory #742

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Prevent Cantera installation to source directory #742

merged 1 commit into from
Nov 7, 2019

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Nov 4, 2019

Please fill in the issue number this pull request is fixing

Fixes #710

Changes proposed in this pull request

  • add check in SConstruct

bryanwweber
bryanwweber reviewed Nov 4, 2019
View reviewed changes
SConstruct Outdated Show resolved Hide resolved
bryanwweber
bryanwweber reviewed Nov 4, 2019
View reviewed changes
Copy link
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can drop the srcnode(), just Dir(".").abspath seems to do the right thing. Also, it seems like this check should be done as soon as the env file is read. There's no need to do any configuration or any other checks if this one is just going to blow everything up anyways.

@ischoegl
Copy link
Member Author

ischoegl commented Nov 4, 2019

I think you can drop the srcnode(), just Dir(".").abspath seems to do the right thing. Also, it seems like this check should be done as soon as the env file is read.

True, and done.

@codecov
Copy link

codecov bot commented Nov 4, 2019 •
edited
Loading

Codecov Report

Merging #742 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   70.86%   70.86%   +<.01%     
==========================================
  Files         374      374              
  Lines       43683    43683              
==========================================
+ Hits        30954    30955       +1     
+ Misses      12729    12728       -1
Impacted Files Coverage Δ
src/transport/GasTransport.cpp 90.79% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce47733...9b620ce. Read the comment docs.

speth
speth approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is simple and effective.

@speth speth merged commit 43d02e9 into Cantera:master Nov 7, 2019
@ischoegl ischoegl deleted the check-prefix branch December 16, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanwweber bryanwweber bryanwweber left review comments

@speth speth speth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message when prefix is set to the source directory
3 participants
@ischoegl @speth @bryanwweber